[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: avoid getting stuck on macvtapN name created outside libvirt




On 03/28/2016 10:26 AM, Laine Stump wrote:
> After the patches that added tracking of in-use macvtap names (commit
> 370608, first appearing in libvirt-1.3.2), if the function to allocate
> a new macvtap device came to a device name created outside libvirt, it
> would retry the same device name MACVLAN_MAX_I (8191) times before

MACVLAN_MAX_ID

cut-n-paste error...

> finally giving up in failure.
> 
> The problem was that virBitmapNextClearBit was always being called
> with "0" rather than the value most recently checked (which would
> increment each time through the loop).
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1321546
> ---
> 
> I'm not sure how this bug snuck in, because this is one of the
> scenarios I tested. The only thing I can think of is that I screwed up
> somehow during a rebase after testing and before posting/pushing (or possibly I had tested these cases in an earlier iteration, but forgot to do so with the final version) :-/ Sigh.
> 
>  src/util/virnetdevmacvlan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK,

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]