[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/3] conf: qemu: Add support for more HyperV Enlightenment features



[...]

>>> --- a/docs/formatdomain.html.in
>>> +++ b/docs/formatdomain.html.in
>>> @@ -1460,6 +1460,11 @@
>>>         <relaxed state='on'/>
>>>         <vapic state='on'/>
>>>         <spinlocks state='on' retries='4096'/>
>>> +      <vpindex state='on'/>
>>> +      <runtime state='on'/>
>>> +      <synic state='on'/>
>>> +      <reset state='on'/>
>>> +      <vendor_id state='on' value='KVM Hv'/>
>>>       </hyperv>
>>>       <kvm>
>>>         <hidden state='on'/>
>>> @@ -1535,6 +1540,42 @@
>>>             <td>on, off; retries - at least 4095</td>
>>>             <td><span class="since">1.1.0 (QEMU only)</span></td>
>>>           </tr>
>>> +        <tr>
>>> +          <td>vpindex</td>
>>> +          <td>Virtual processor index</td>
>>> +          <td> on, off</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>>> +        <tr>
>>> +          <td>runtime</td>
>>> +          <td>Processor time spent on running guest code and on
>>> behalf of guest code</td>
>>> +          <td> on, off</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>>> +        <tr>
>>> +          <td>synic</td>
>>> +          <td>Enable Synthetic Interrupt Controller (SyNIC)</td>
>>> +          <td> on, off</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>>> +        <tr>
>>> +          <td>stimer</td>
>>> +          <td>Enable SyNIC timers</td>
>>> +          <td> on, off</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>>> +        <tr>
>>> +          <td>reset</td>
>>> +          <td>Enable hypervisor reset</td>
>>> +          <td> on, off</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>>> +        <tr>
>>> +          <td>vendor_id</td>
>>> +          <td>Set hypervisor vendor id</td>
>>> +          <td>on, off; value - string, up to 12 characters</td>
>>> +          <td><span class="since">1.3.3 (QEMU only)</span></td>
>>> +        </tr>
>> s/QEMU only/requires QEMU 1.5/g
>>
>> or
>>
>> s/QEMU only/QEMU 1.5 or later)/g
>>
>> Do you have a preference?  The first one usually implies the "or later".
>> Since there's no caps check for the feature, we should at least document
>> when they were added.
> 
> let it be the first one (one character shorter :) )
> 

OK - on the first pass my eyes didn't see what my fingers typed (1.5,
when it should have been 2.5 ;-))... time to punish the fingers.  I'll
drop the requires too since the column header is "Since"...

>>
>> I see that 'hv-crash' was added in 1.5 (qemu commit id 'f2a53c9e'), but
>> not added here - any reason why not?
> 
> just because it's already in libvirt (commit 59fc0d06)
> 
>>
>> In order to be consistent, the others probably should be updated as well
>> - each was qemu 2.0 or later.
>>
>> There was also 'hv-time' added in 2.0 (qemu commit id '48a5f3bcb') -
>> should that be added to (perhaps a separate patch though).
> 
> same reason (commit 600bca59)
> 

Hmm. I see... These two were added a bit differently, but the feature
bits get added. I was being myopic and just comparing the for loop.
Those are bits the user would have no need to provide so better to not
document since they're handled by other XML.

I'll push this shortly...

John

[...]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]