[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rbd: use unsigned long long instead of uint64_t



On Mon, Mar 28, 2016 at 15:19:36 +0800, Shanzhi Yu wrote:
> Fix below error:
> storage/storage_backend_rbd.c: In function 'virStorageBackendRBDSetAllocation':
> storage/storage_backend_rbd.c:337:5: error: format '%llu' expects argument of type 'long long unsigned int', but argument 8 has type 'uint64_t' [-Werror=format=]
>     VIR_DEBUG("Found %llu bytes allocated for RBD image %s",
> 
> Signed-off-by: Shanzhi Yu <shyu redhat com>
> ---
>  src/storage/storage_backend_rbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NACK, the correct approach is to use "size_t" as
virStorageBackendRBDRefreshVolInfoCb is getting that as the size info.
The callback has to be fixed too. I've pushed the correct version.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]