[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] virsh: Add support for byte granularity and scaled integers for virsh block APIs



On Thu, Mar 24, 2016 at 15:48:57 -0400, John Ferlan wrote:
> 
> 
> On 03/18/2016 04:56 AM, Peter Krempa wrote:
> > Quite some time ago we've added support for byte granularity for block job
> > bandwidth. Make it work in virsh and add support for scaled integers too.
> > 
> > Peter Krempa (6):
> >   vsh: Tweak error message for scaled integers
> >   vsh: Refactor vshCommandOptScaledInt
> >   virsh: blockjob: Support --bytes and scaled integers as bandwidth
> >   virsh: blockcommit: Support --bytes and scaled integers
> >   virsh: blockcopy: Support --bytes and scaled integers
> >   virsh: blockpull: Support --bytes and scaled integers
> > 
> >  tests/virsh-optparse |  6 ++---
> >  tools/virsh-domain.c | 73 ++++++++++++++++++++++++++++++++++++----------------
> >  tools/virsh.pod      | 37 ++++++++++++++------------
> >  tools/vsh.c          | 66 +++++++++++++++++++++++++++++++++++++++++------
> >  tools/vsh.h          |  4 +++
> >  5 files changed, 137 insertions(+), 49 deletions(-)
> > 
> 
> 
> Note specific nits from patch 3
> 
> I think the commit messages for patches 4-6 shouldn't be:
> 
> "Reuse the approach and helper from the last patch."
> 
> since "last patch" causes me to go find the "last patch"...
> 
> cut-copy-paste what they're using vshBlockJobOptionBandwidth and
> allowing the --bytes on the set.
> 
> If we really wanted to be picky, patch 3 could introduce the new
> function with patches 4-7 using it and indicating so in their commit
> messages.
> 
> ACK series with at least the typos fixed and commit messages adjusted.
> Your choice if you want to extract out the function.

I've split out the function addition and fixed the commit messages and
comments. Thanks; pushed.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]