[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] qemu: fix automatic NUMA pinning with memory hotplug



On Wed, Mar 30, 2016 at 07:26:09 -0400, John Ferlan wrote:
> 
> 
> On 03/29/2016 10:52 AM, Peter Krempa wrote:
> > We forgot to propagate the automatic nodeset and reported non-ideal errors.
> > 
> > Peter Krempa (3):
> >   qemu: command: Pass numad nodeset when formatting memory devices at
> >     boot
> >   qemu: command: Split up formatting of -numa and memory devices
> >   qemu: hotplug: Improve error when hotpluging memory with
> >     auto-placement
> > 
> >  src/conf/numa_conf.c     | 20 +++++++++++++++++---
> >  src/conf/numa_conf.h     |  1 +
> >  src/libvirt_private.syms |  1 +
> >  src/qemu/qemu_command.c  | 27 ++++++++++++++-------------
> >  src/qemu/qemu_hotplug.c  |  7 +++++++
> >  5 files changed, 40 insertions(+), 16 deletions(-)
> > 
> 
> ACK series (seems safe to me),

I'll shortly push patches 1 and 2 since 1 is a pretty straightforward
bug fix and 2 is a no-op. In patch 3 I've noticed that the
function I've created would be duplicate with
virDomainNumatuneHasPlacementAuto so I'll repost it later.

Thanks.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]