[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/7] docs: Some website tweaks




On 03/30/2016 10:19 AM, Andrea Bolognani wrote:
> Basically, the navigation menu is *way* too big, and takes
> the focus away from the actual content. Plus it's very easy
> for longish words to overflow it (see "Authentication" in
> the screenshots below).
> 
> The headers are probably bigger than needed as well, so
> I've scaled them down. Using Wikipedia for comparison,
> you can see the new size is more comparable to what they
> use.
> 
> Some other minor cleanups have been included as well.
> 
> Before[1] and after[2] screenshots for your convenience.
> 
> Cheers.
> 
> 
> [1] http://i.imgur.com/MZchAWD.png
> [2] http://i.imgur.com/BXepLTh.png
> 
> Andrea Bolognani (7):
>   docs: Adjust vertical whitespace in CSS
>   docs: Remove empty CSS rule
>   docs: Don't use <strong> in headers
>   docs: Make menu entries smaller
>   docs: Don't use bold text for menu entries
>   docs: Use bold text for all headers
>   docs: Make most headers a bit smaller
> 
>  docs/apps.html.in |  2 +-
>  docs/generic.css  | 15 +++++++++------
>  docs/libvirt.css  | 30 ++++++------------------------
>  3 files changed, 16 insertions(+), 31 deletions(-)
> 

Lot's of style churn here lately... Ironically the view I get from
libvirt.org has always had slightly bolder and larger text as opposed
the view I get when viewing changes in a local branch. Personally, I
like the larger, bolder text since it's easier to read than some font
style that's meant for a mobile phone.  As long as we don't start adding
graphics and flash, we're good ;-)!

Anyway just a note that patch 3 removes the h1 font-weight bold, but
patch 6 claims all headers except h1 were already bold... Not a big deal
due to the end result, but I assume they should be together.

My only other comment would be regarding  <dt> elements - I would prefer
to see them use a slightly bolder text so that they stand out from the
rest of the text. If I read the tea leaves correctly that would be an
adjustment to the <dt> to have "font-weight: bold;".

Other than that you have an ACK from me...  and it should be safe for
freeze...

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]