[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/9] stream error reporting fixes



On 25.04.2016 20:46, Cole Robinson wrote:
> This series attempts to address various stream finish/abort error
> reporting issues:
> 
> * Unclear error messages
> * virStreamAbort always returns an error
> * Spurious errors logged on the daemon side
> * Various issues in stream error cleanup (found through code inspection)
> 
> Cole Robinson (9):
>   fdstream: separate out virCommandPtr cleanup
>   fdstream: Report error with virProcessTranslateStatus
>   fdstream: Raise explicit error when iohelper gets SIGPIPE
>   daemon: stream: Close stream on send failure
>   daemon: stream: don't update events if stream->closed
>   daemon: stream: set stream->closed on removal
>   rpc: protocol: Clarify VIR_NET_ERROR usage with streams
>   daemon: stream: Don't force error when client aborts
>   fdstream: don't raise error on SIGPIPE if abort requested
> 
>  daemon/stream.c          | 42 +++++++++++++++++-------
>  src/fdstream.c           | 84 ++++++++++++++++++++++++++++++------------------
>  src/rpc/virnetprotocol.x |  7 ++--
>  3 files changed, 88 insertions(+), 45 deletions(-)
> 

ACK series

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]