[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Refresh RTC adjustment on qemuProcessReconnect



On Tue, May 03, 2016 at 09:31:13 +0200, Michal Privoznik wrote:
> On 03.05.2016 08:14, Peter Krempa wrote:

[...]

> > As long as it's guaranteed that any target qemu supported by libvirt 
> > does support the interrogation you are going to do it's probably fine.
> > 
> > The problem with your patch is that qom-get was added in qemu 1.1
> > whereas libvirt supports versions since 0.12
> > 
> > This would effectively reduce compatibility to 1.1 which we should not
> > do as a side effect of a unrelated change.
> 
> Okay, so if I make that check less drastic, do I have your ACK or do you
> want me to send v2?

I would have explicitly stated it if I did not want to see it.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]