[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/3] qemu: Generate channel target paths on hotplug as well



On Thu, Apr 28, 2016 at 04:43:42PM +0200, Martin Kletzander wrote:
> Since commit 714080791778e3dfbd484ccb3953bffd820b8ba9, qemu agent
> channel cannot be plugged in because we won't generate its path
> automatically.  Let's not only fix that, but also add tests for it so
> next time it's checked for.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1322210
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---

[...]

> diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
> index 924114668450..19af173543a5 100644
> --- a/tests/qemuhotplugtest.c
> +++ b/tests/qemuhotplugtest.c
> @@ -97,6 +97,9 @@ qemuHotplugCreateObjects(virDomainXMLOptionPtr xmlopt,
> 
>      (*vm)->def->id = QEMU_HOTPLUG_TEST_DOMAIN_ID;
> 
> +    if (qemuDomainSetPrivatePaths(&driver, *vm) < 0)
> +        goto cleanup;
> +
>      ret = 0;
>   cleanup:
>      return ret;
> @@ -494,6 +497,13 @@ mymain(void)
>                     "device_del", QMP_DEVICE_DELETED("scsi0-0-0-5") QMP_OK,
>                     "human-monitor-command", HMP(""));
> 
> +    DO_TEST_ATTACH_LIVE("hotplug-base", "qemu-agent", false, true,
> +                        "chardev-add", QMP_OK,
> +                        "device_add", QMP_OK);

This seems to depend on this patch:
<https://www.redhat.com/archives/libvir-list/2016-April/msg01912.html>

Pavel

> +    DO_TEST_DETACH("hotplug-base", "qemu-agent-detach", false, false,
> +                   "device_del", QMP_OK,
> +                   "chardev-remove", QMP_OK);
> +
>      qemuTestDriverFree(&driver);
>      return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
>  }

[...]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]