[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] admin: Introduce virAdmServerLookupClient



On Fri, Apr 29, 2016 at 03:45:53PM +0200, Erik Skultety wrote:
> Just like with server-related APIs, before any of client-based APIs can be
> called, a reference to a client-side client object needs to be obtained. For
> this purpose, a lookup method should exist. Apart from the client retrieval
> logic, a new error code for non-existent client had to be added as well.
> 
> Signed-off-by: Erik Skultety <eskultet redhat com>
> ---
>  daemon/admin_server.c           | 10 ++++++++++
>  daemon/admin_server.h           |  4 ++++
>  include/libvirt/libvirt-admin.h |  5 +++++
>  include/libvirt/virterror.h     |  1 +
>  src/admin/admin_protocol.x      | 17 ++++++++++++++++-
>  src/admin_protocol-structs      |  9 +++++++++
>  src/libvirt-admin.c             | 36 ++++++++++++++++++++++++++++++++++++
>  src/libvirt_admin_private.syms  |  2 ++
>  src/libvirt_admin_public.syms   |  1 +
>  src/rpc/virnetserver.c          | 23 +++++++++++++++++++++++
>  src/rpc/virnetserver.h          |  3 +++
>  src/util/virerror.c             |  6 ++++++
>  12 files changed, 116 insertions(+), 1 deletion(-)

> +virAdmClientPtr
> +virAdmServerLookupClient(virAdmServerPtr srv,
> +                         unsigned long long id,
> +                         unsigned int flags);
> +
>  # ifdef __cplusplus
>  }
>  # endif
> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
> index c6abdf7..2ec560e 100644
> --- a/include/libvirt/virterror.h
> +++ b/include/libvirt/virterror.h
> @@ -314,6 +314,7 @@ typedef enum {
>      VIR_ERR_MIGRATE_FINISH_OK = 93,     /* Finish API succeeded but it is expected to return NULL */
>      VIR_ERR_AUTH_UNAVAILABLE = 94,	/* authentication unavailable */

>      VIR_ERR_NO_SERVER = 95,             /* Server was not found */
> +    VIR_ERR_NO_CLIENT = 96,             /* Client was not found */
>  } virErrorNumber;
>  

Should these be added to the whitelist in daemonErrorLogFilter?

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]