[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Allow blkdeviotune to take human readable values



On 05/03/2016 01:52 PM, Nishith Shah wrote:
> On Tue, May 3, 2016 at 11:17 PM, Cole Robinson <crobinso redhat com
> <mailto:crobinso redhat com>> wrote:
> 
>     On 05/03/2016 10:09 AM, Nishith Shah wrote:
>     > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is
>     > no need to pass values in raw bytes, which is seldom the case.
> 
>     Also, on v2, you can add this bug link to the commit message:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=885380 
> 
> I was going too, but wasn't sure if that would be allowed in a commit message,
> will do in the next patches.
> 

If in doubt, check out other examples from 'git log' and follow the
conventions you see. For example I suggest a subject line like:

virsh: blkdeviotune: accept human readable values

At least the intro 'virsh:' bit is pretty standard

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]