[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] virjson: Make pretty format more compact



On Thu, May 05, 2016 at 09:11:54 +0200, Peter Krempa wrote:
> On Wed, May 04, 2016 at 17:09:51 +0200, Jiri Denemark wrote:
> > json_reformat uses two spaces for when indenting nested objects, let's
> > do the same. The result of virJSONValueToString will be exactly the same
> > as json_reformat would produce.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar redhat com>
> > ---
> 
> I guess it's good to have an external tool doing the same formatting as
> libvirt.

Yes, you can just update any json manually, filter it through
json_reformat and our tests which produce json strings and compare them
to the expected string will just be happy with it.

I pushed this series, thanks for the review.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]