[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret



[...]

>> diff --git a/configure.ac b/configure.ac
>> index 88e2e20..3cabd5e 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1264,6 +1264,7 @@ if test "x$with_gnutls" != "xno"; then
>>    ]])
>>  
>>    AC_CHECK_FUNCS([gnutls_rnd])
>> +  AC_CHECK_FUNCS([gnutls_cipher_encrypt])
> 
> This change should go into the previous commit since it's that one who
> uses it.
> 

Putting this in patch 7, means qemuDomainSecretHaveEncrypt will be
active and we "could" try to add an IV secret with no teeth. As I noted
in my cover - 7 and 8 were split to make for a smaller pile of code to
review. I could combine them.

FWIW: I tried to "separate" things a bit more for the "last" patch. In
doing so I found that having qemuDomainSecretHaveEncrypt and
qemuDomainSecretIVSetup in patch 7 as static and "unused" (if I didn't
make the modification to add qemuDomainSecretSetup) would cause a build
error. I had forgotten about using the "ATTRIBUTE_UNUSED" trick in order
to avoid the build error. If I went back and took this approach, then
qemuDomainSecretSetup gets introduced in patch 8.

John

>>  
>>    CFLAGS="$old_CFLAGS"
>>    LIBS="$old_LIBS"
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index b56277f..27e31ec 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -607,9 +607,227 @@ qemuNetworkDriveGetPort(int protocol,
>>  }
>>  
> 
> Michal
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]