[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain



On Fri, May 06, 2016 at 11:23:13 -0400, John Ferlan wrote:

[...]

> 
> Do you believe it still would be worthwhile to add:
> 
>     if (virDomainDiskGetFormat(def) == VIR_STORAGE_FILE_NONE)
>         virDomainDiskSetFormat(def, VIR_STORAGE_FILE_RAW);
> 
> in virStorageTranslateDiskSourcePool in the ISCSI case for MODE_HOST?

You can do that only if format detection is disabled, otherwise it would
not be possible to use it. The rest of the code needs to handle the
possibility that the format needs to be detected.

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]