[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] domaincaps: Report graphics spiceGL



On 05/09/2016 05:27 AM, Michal Privoznik wrote:
> On 08.05.2016 19:49, Cole Robinson wrote:
>> Reports a tristate enum value for acceptable video model=virtio
>> <acceleration accel3d=XXX/>.
>>
>> Wire it up for qemu too. 'no' is always a valid value, so we
>> unconditionally report it.
>> ---
>>  docs/formatdomaincaps.html.in                           | 9 +++++++++
>>  src/conf/domain_capabilities.c                          | 1 +
>>  src/conf/domain_capabilities.h                          | 2 ++
>>  src/qemu/qemu_capabilities.c                            | 4 ++++
>>  tests/domaincapsschemadata/domaincaps-full.xml          | 5 +++++
>>  tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml | 3 +++
>>  tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml  | 4 ++++
>>  tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml  | 3 +++
>>  tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml  | 3 +++
>>  tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml  | 3 +++
>>  tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml  | 3 +++
>>  tests/domaincapstest.c                                  | 1 +
>>  12 files changed, 41 insertions(+)
>>
>> diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
>> index c424107..b87a45a 100644
>> --- a/docs/formatdomaincaps.html.in
>> +++ b/docs/formatdomaincaps.html.in
>> @@ -268,6 +268,10 @@
>>          &lt;value&gt;qxl&lt;/value&gt;
>>          &lt;value&gt;virtio&lt;/value&gt;
>>        &lt;/enum&gt;
>> +      &lt;enum name='virtioAccel3D'&gt;
>> +        &lt;value&gt;yes&lt;/value&gt;
>> +        &lt;value&gt;no&lt;/value&gt;
>> +      &lt;/enum&gt;
>>      &lt;/video&gt;
>>      ...
>>    &lt;/devices&gt;
>> @@ -278,6 +282,11 @@
>>        <dt><code>modelType</code></dt>
>>        <dd>Options for the <code>type</code> attribute of the
>>        &lt;video&gt;&lt;model&gt; element.</dd>
>> +
>> +      <dt><code>spiceGL</code></dt>
> 
> Copy paste error. This should have been virtioAccel3D. This is more or
> less the same problem (maybe too strong term though) that I've raised in
> 3/5. Just accel3D perhaps? Otherwise the code looks good.

Fixed locally (and the subject... not sure how that happened)

I've pushed patches 1, 2, and 4 since you ACKd and they don't seem
controversial. Thanks!

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]