[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH REPOST 01/38] virlog: Return void instead of int in virLogReset<Foo> methods



On 05/04/2016 10:30 AM, Erik Skultety wrote:
> In this particular case, reset is meant as clearing the whole list of
> outputs/filters, not resetting it to a predefined default setting. Looking at
> it from that perspective, returning the number of records removed doesn't help
> the caller in any way (not that any of the callers would actually check for
> it). Well, callers could detect an error from the number of successfully
> removed records, but the only thing that can fail in virLogReset is force
> closing a file descriptor in which case the error isn't propagated back to
> virLogReset anyway. Conclusion: there is no practical use for having a return
> type of 'int' rather than 'void' in this case.

ACK

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]