[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu.conf: spaces correction



On 09.05.2016 14:21, poma wrote:
> 
> libvirt/qemu.conf: spaces correction
> 
> ---
>  src/qemu/qemu.conf | 42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)

Okay. But what I'd like you to do is:

1) Explain in commit message why are you doing this change.
2) Add the following missed chunk:


diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index 5cf4599..aa94beb 100644
--- a/src/qemu/qemu.conf
+++ b/src/qemu/qemu.conf
@@ -445,7 +445,7 @@
 # is considered broken. In other words, the connection is
 # automatically closed approximately after
 # keepalive_interval * (keepalive_count + 1) seconds since the last
-# message received from the daemon.  If keepalive_interval is set to
+# message received from the daemon. If keepalive_interval is set to
 # -1, qemu driver will not send keepalive requests during
 # peer-to-peer migration; however, the remote libvirtd can still
 # send them and source libvirtd will send responses. When

3) Tell us who you are. Unfortunately, we don't accept patches supplied
under a nickname or a fake name. You don't have to sign off the patch.
Just make sure that From: line is in form "Name Surname
<email address>". I guess if you look around the list there are plenty
of examples of good practice.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]