[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu.conf: spaces correction



On Tue, May 10, 2016 at 11:58:59AM -0400, Cole Robinson wrote:
> On 05/10/2016 11:56 AM, Michal Privoznik wrote:
> > On 10.05.2016 17:23, Ján Tomko wrote:
> >> On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote:
> >>>
> >>> libvirt/qemu.conf: spaces correction
> >>>
> >>> ---
> >>>  src/qemu/qemu.conf | 42 +++++++++++++++++++++---------------------
> >>>  1 file changed, 21 insertions(+), 21 deletions(-)
> >>>
> >>> @@ -285,11 +285,11 @@
> >>>  
> >>>  
> >>>  # The default format for Qemu/KVM guest save images is raw; that is, the
> >>> -# memory from the domain is dumped out directly to a file.  If you have
> >>> +# memory from the domain is dumped out directly to a file. If you have
> >>>  # guests with a large amount of memory, however, this can take up quite
> >>> -# a bit of space.  If you would like to compress the images while they
> >>> +# a bit of space. If you would like to compress the images while they
> >>>  # are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "xz"
> >>> -# for save_image_format.  Note that this means you slow down the process of
> >>> +# for save_image_format. Note that this means you slow down the process of
> >>>  # saving a domain in order to save disk space; the list above is in descending
> >>>  # order by performance and ascending order by compression ratio.
> >>>  #
> >>
> >> Most of the changes remove double spacing between sentences.
> >> This was intentional and I do not think it needs to be corrected.
> > 
> > Can you elaborate more on the reasoning behind this intent?
> 
> https://en.wikipedia.org/wiki/Sentence_spacing
> 
> Basically some people use two spaces after a period, some people don't.

On balance libvirt only uses a single space, though there are more uses
of double space that I expected.

$ git grep -E  "\.  \w"  | wc -l
4540

$ git grep -E  "\. \w"  | wc -l
17305

Quite alot of the double spaces actually come from the GNU license
plate header !

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]