[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] headers: Remove unnecessary keyword extern from function declaration



On 11/05/16 00:51, Cole Robinson wrote:
> On 05/10/2016 09:49 AM, Erik Skultety wrote:
>> Usage of this keyword in front of function declaration that is exported via a
>> header file is unnecessary, since internally, this has been the default for most
>> compilers for quite some time.
>>
>> Signed-off-by: Erik Skultety <eskultet redhat com>
>> ---
>>  src/conf/capabilities.h           | 28 +++++++-------
>>  src/cpu/cpu.h                     | 24 ++++++------
>>  src/cpu/cpu_map.h                 |  2 +-
>>  src/lxc/lxc_fuse.h                |  6 +--
>>  src/util/virhashcode.h            |  2 +-
>>  src/util/virlog.h                 | 78 +++++++++++++++++++--------------------
>>  src/util/virstats.h               |  4 +-
>>  src/xen/block_stats.h             |  4 +-
>>  src/xen/xen_driver.h              |  2 +-
>>  src/xenapi/xenapi_driver.h        |  2 +-
>>  tools/virt-host-validate-common.h | 62 +++++++++++++++----------------
>>  tools/virt-host-validate-lxc.h    |  2 +-
>>  tools/virt-host-validate-qemu.h   |  2 +-
>>  13 files changed, 109 insertions(+), 109 deletions(-)
> 
> ACK
> 
> Thanks,
> Cole
> 
Pushed, thanks.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]