[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH REPOST 0/5] admin: Introduce APIs to get/set client processing



On 11.05.2016 12:20, Erik Skultety wrote:
> This is just a rebased version of
> https://www.redhat.com/archives/libvir-list/2016-April/msg00466.html.
> Patches 1/7 and 2/7 of the original series were already pushed with another
> series.
> 
> Erik Skultety (5):
>   virnetserver: Introduce client processing controls getters
>   admin: Introduce some public constants related to client processing
>     controls
>   admin: Introduce virAdmServerGetClientProcessingControls
>   admin: Introduce virAdmServerSetClientProcessingControls
>   virt-admin: Introduce commands srv-clients-info and srv-clients-set
> 
>  daemon/admin.c                  |  86 +++++++++++++++++++
>  daemon/admin_server.c           |  76 +++++++++++++++++
>  daemon/admin_server.h           |  10 +++
>  include/libvirt/libvirt-admin.h |  52 ++++++++++++
>  src/admin/admin_protocol.x      |  30 ++++++-
>  src/admin/admin_remote.c        |  74 +++++++++++++++++
>  src/admin_protocol-structs      |  20 +++++
>  src/libvirt-admin.c             |  89 ++++++++++++++++++++
>  src/libvirt_admin_private.syms  |   3 +
>  src/libvirt_admin_public.syms   |   2 +
>  src/rpc/virnetserver.c          |  83 +++++++++++++++++++
>  src/rpc/virnetserver.h          |   9 ++
>  tools/virt-admin.c              | 177 ++++++++++++++++++++++++++++++++++++++++
>  13 files changed, 710 insertions(+), 1 deletion(-)
> 

In general, I like this approach. And I'm very tempted to ACK it. But
I'd rather have some discussion on the naming in patches 3 and 4. If we
can come up with something better, you have my ACK.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]