[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool



[...]


> 
> While there's nothing wrong with this patch, after it we have this pair
> of ClearVols() + refreshPool() occurring all over the place. Should we
> create a wrapper function over it so we not miss anything similar in the
> future?
> 

I've thrashed that idea around a few times as well... Never quite sure
if some sort of 'virStoragePoolRefreshPool()' should be generated or to
make the virStoragePoolObjClearVols() call in each refreshPool callback.

To a degree, I see value in forcing each backend to make the decision
whether to "update"/refresh it's list or just take the large hammer
method and generate the list all over since it's a lot easier than
knowing what your current list is, deciding if the next thing you find
is new or not, and then deciding what was on the list before you started
the refresh and no longer is found, thus must be removed. Currently each
backend just takes the large hammer approach.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]