[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 11/12] spice: introduce spice_auto_unix_socket config option



On Wed, May 11, 2016 at 08:14:36PM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina <phrdina redhat com> wrote:
> > Signed-off-by: Pavel Hrdina <phrdina redhat com>
> > ---
> 
> make check fails :
> test_libvirtd_qemu.aug:68.3-145.28:exception thrown in test
> test_libvirtd_qemu.aug:68.8-.34:exception: Iterated lens matched less
> than it should
>     Lens: ./qemu/libvirtd_qemu.aug:113.13-.43:
>       Last match: ./qemu/libvirtd_qemu.aug:109.17-.31:
>     Error encountered at 13:0 (324 characters into string)
>     < = "/etc/pki/libvirt-spice"\n|=|spice_auto_unix_socket = 1\ns>

I guess that I should install augeas :) thanks.

> Tbh, I don't understand the need for unix socket listening when using
> libvirt. If you use libvirt to manage your VM, you may as well just
> use it to connect to the display (virti-viewer --attach). These avoid
> having extra listening sockets. Other than that, looks good to me.

This will allow us to add another way how to restrict access to the graphics
console. I'll add a <seclabel> for the <listen type='socket'/> and administrator
can set a uid/gid to restrict access to this socket.

Pavel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]