[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] qemu: Change from SecretIV or _IV to SecretAES or _AES



On Thu, May 12, 2016 at 07:49:32 -0400, John Ferlan wrote:
> The preferred name will be AES not IV, change current references
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/qemu/qemu_command.c |  4 ++--
>  src/qemu/qemu_domain.c  |  6 +++---
>  src/qemu/qemu_domain.h  | 14 +++++++-------
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 

[...]

> diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
> index a03bdc5..5e825b3 100644
> --- a/src/qemu/qemu_domain.h
> +++ b/src/qemu/qemu_domain.h

[...]

> @@ -255,11 +255,11 @@ struct _qemuDomainSecretPlain {
>      size_t secretlen;
>  };
>  
> -# define QEMU_DOMAIN_IV_KEY_LEN 16      /* 16 bytes for 128 bit random */
> -                                        /*    initialization vector key */
> -typedef struct _qemuDomainSecretIV qemuDomainSecretIV;
> -typedef struct _qemuDomainSecretIV *qemuDomainSecretIVPtr;
> -struct _qemuDomainSecretIV {
> +# define QEMU_DOMAIN_AES_KEY_LEN 16      /* 16 bytes for 128 bit random */

This should be QEMU_DOMAIN_AES_IV_LEN. Since it's the length of the
initialization vector.

> +                                         /*    initialization vector key */

s/key//

The word key is reserved for the shared secret. The IV is shared but
not secret.

> +typedef struct _qemuDomainSecretAES qemuDomainSecretAES;
> +typedef struct _qemuDomainSecretAES *qemuDomainSecretAESPtr;
> +struct _qemuDomainSecretAES {
>      char *username;
>      char *alias;      /* generated alias for secret */
>      char *iv;         /* base64 encoded initialization vector */

Here it's used correctly.

> @@ -272,7 +272,7 @@ struct _qemuDomainSecretInfo {
>      qemuDomainSecretInfoType type;
>      union {
>          qemuDomainSecretPlain plain;
> -        qemuDomainSecretIV iv;
> +        qemuDomainSecretAES aes;
>      } s;
>  };

ACK with the tweaks above.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]