[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/2] Enable QEMU_CAPS_PCI_ROMBAR unconditionally



This capability was not handled correctly, causing aarch64
guests having

  <interface type='network'>
    ...
    <rom bar='off'/>
  </interface>

to fail at startup with

  error: unsupported configuration: rombar and romfile not
         supported in this QEMU binary

I'm not sure whether we should drop the QEMU_CAPS_PCI_ROMBAR
capability entirely now that it's enabled unconditionally and
there is no code checking for it; as I understand it, we don't
ever drop capabilities, hence the current implementation.


Andrea Bolognani (2):
  qemu: Enable QEMU_CAPS_PCI_ROMBAR unconditionally
  qemu: Stop checking for QEMU_CAPS_PCI_ROMBAR

 src/qemu/qemu_capabilities.c                       | 46 ++++++++++++----------
 src/qemu/qemu_command.c                            | 12 ++----
 tests/qemucapabilitiesdata/caps_1.2.2-1.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_2.6.0-1.aarch64.xml  |  1 +
 .../qemucapabilitiesdata/caps_2.6.0-1.ppc64le.xml  |  1 +
 .../qemucapabilitiesdata/caps_2.6.0-2.aarch64.xml  |  1 +
 6 files changed, 33 insertions(+), 29 deletions(-)

-- 
2.5.5


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]