[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Fix default vram setting for libxl



On 05/16/2016 09:32 AM, Cole Robinson wrote:
> On 05/16/2016 05:47 AM, Joao Martins wrote:
>> On 05/12/2016 09:30 AM, Ján Tomko wrote:
>>> On Wed, May 11, 2016 at 03:47:06PM -0600, Jim Fehlig wrote:
>>>> On 05/11/2016 04:57 AM, Ján Tomko wrote:
>>>>> An alternative to
>>>>> https://www.redhat.com/archives/libvir-list/2016-May/msg00700.html
>>>>> 1462942877-31516-1-git-send-email-jfehlig suse com
>>>>>
>>>>> This series adds a call to DeviceDefPostParse for the implicit video
>>>>> which is being in the DomainDefPostParse phase, after DeviceDefPostParse
>>>>> has been done on all the existing devices.
>>>>
>>>> I much prefer this approach over fixing it in the driver, but I'm not terribly
>>>> familiar with this code, hence the attempt to fix it in libxl.
>>>>
>>>>>
>>>>> Ján Tomko (3):
>>>>>   Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse
>>>>>   Call per-device post-parse callback even on implicit video
>>>>>   Fill out default vram in DeviceDefPostParse
>>>>
>>>> I reviewed and tested the patches and did not notice any problems - ACK series.
>>>>
>>>
>>> Thanks, pushed now.
>> I wonder if this series should be also on v1.3.3-maint branch alongside commit
>> 96b21fb ("Fix tests to include video ram size") and Jim's series (400e716 b90c4b5
>> "libxl: A few more fixes related to vram") ?
>>
>> The bug https://bugzilla.redhat.com/show_bug.cgi?id=1334557 was originally reported
>> on v1.3.3.1 so probably requires theses fixes too.
>>
> 
> I've pushed them to v1.3.3-maint now

Also note there was another bug that made virt-install fail, something wrong
with the <graphics> XML output I suspect, but I didn't dig into it:

https://bugzilla.redhat.com/show_bug.cgi?id=1334562

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]