[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: More qemu_monitor_json cleanups



On Mon, May 16, 2016 at 10:05:04AM -0400, John Ferlan wrote:
> Recent adjustments to the code produced a litany of coverity false
> positives, but only because the "standard" procedure of setting a
> variable to NULL after it was assigned to something else and keeping
> the *Free/*FREE call in the cleanup path wasn't kept. So this patch
> makes those adjustments (assign variable to NULL and remove the if
> 'ret < 0' condition to clean it up).
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/qemu/qemu_monitor_json.c | 46 ++++++++++++++++++++++++--------------------
>  1 file changed, 25 insertions(+), 21 deletions(-)
> 

ACK

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]