[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] libxl: Resolve Coverity RESOURCE_LEAK



The commit summary should describe the change being made, e.g:
s/Resolve Coverity RESOURCE_LEAK/free migration cookie/

On Mon, May 16, 2016 at 10:05:05AM -0400, John Ferlan wrote:
> Commit id 'f9edcfa4' added cookie manipulation for libxl; however, some
> cookie crumb cleanup was missed.
> 
> In libxlDomainMigrationBegin, the cookie is allocated and baked; however,
> the mig ingredients weren't cleaned up.
> 
> In libxlDomainMigrationPrepare, when the 'mig' cookie is added to the
> args, set the 'mig = NULL'; otherwise, other failure paths between when
> the code ate the cookie data and when it was added to args would fail
> to clean up the crumbs.
> 

Crediting Coverity would better fit here in the commit message body, e.g.:
Found by Cinderel^WCoverity.

> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/libxl/libxl_migration.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

ACK

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]