[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses



On 16.05.2016 12:06, Chun Yan Liu wrote:
> 
> 
>>>> On 5/14/2016 at 07:47 AM, in message <5736677D 8030209 suse com>, Jim Fehlig
> <jfehlig suse com> wrote: 
>> On 05/13/2016 12:21 AM, Chunyan Liu wrote: 


>>  
>> It's unfortunate this is a copy-paste from the qemu driver. The code is not 
>> trivial and any bug fixes in one copy could be missed in the other. A lot of  
>> the 
>> function is domain related, so probably can't be abstracted further to the 
>> network code. Have you considered approaches that allow the drivers to share 
>> this code?
> 
> Well, it can be extracted and placed in bridge_driver.c as networkGetDHCPInterfaces,
> but I don't know if that is acceptable?

I guess it is. We like it when code is shared instead of copied over.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]