[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] qemu: format SLIC ACPI table command line



On 05/17/2016 11:24 AM, John Ferlan wrote:
> 
> 
> On 05/13/2016 10:52 AM, Ján Tomko wrote:
>> <os>
>>   <acpi table="slic">/path/to/acpi/table/file</acpi>
>> </os>
>>
>> will result in:
>>
>> -acpitable sig=SLIC,file=/path/to/acpi/table/file
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1327537
>> ---
>>  src/qemu/qemu_command.c                             |  4 ++++
>>  tests/qemuxml2argvdata/qemuxml2argv-acpi-table.args | 19 +++++++++++++++++++
>>  tests/qemuxml2argvtest.c                            |  2 ++
>>  3 files changed, 25 insertions(+)
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-acpi-table.args
>>
> 
> Is there a need for a capability check?  When was this added to QEMU?
> 
> I see there is one added for "-dtb" (commit id '0b3509e24')
> 
> ACK for what's here, but can we get the answer for whether there's
> a need for a caps bit check before push.
> 

IMO just for giving a mildly nicer error on the command line for an uncommon
config it's not worth adding a feature check (i've made this mistake too).

One day it may be worth adding feature checks for basically everything, but
only to expose the feature list to apps through domcapabilities

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]