[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/5] Automatically choose usable GIC version



On Tue, 2016-05-17 at 00:00 +0200, Andrea Bolognani wrote:
> Changes from [v1]:
> 
>   * Factor away some of the logic to
>     virQEMUCapsSupportsGICVersion(), as suggested by,
>     and based on a first implementation by, Cole
> 
>   * Factor away the common test suite bits to
>     testutilsqemu.{h,c} to avoid code duplication
> 
> 
> [v1] https://www.redhat.com/archives/libvir-list/2016-May/msg00637.html
> 
> Andrea Bolognani (5):
>   qemu: Add virQEMUCapsSupportsGICVersion()
>   qemu: Automatically choose usable GIC version
>   qemu: Add virQEMUCapsSetGICCapabilities()
>   tests: Prepare to have different usable GIC versions
>   tests: Try different usable GIC versions
> 
>  src/qemu/qemu_capabilities.c                       |  91 ++++++++++--
>  src/qemu/qemu_capabilities.h                       |   9 ++
>  src/qemu/qemu_domain.c                             |  49 +++++--
>  .../qemuxml2argv-aarch64-gic-none-both.args        |   1 +
>  .../qemuxml2argv-aarch64-gic-none-both.xml         |   1 +
>  .../qemuxml2argv-aarch64-gic-none-v2.args          |   1 +
>  .../qemuxml2argv-aarch64-gic-none-v2.xml           |   1 +
>  .../qemuxml2argv-aarch64-gic-none-v3.args          |   1 +
>  .../qemuxml2argv-aarch64-gic-none-v3.xml           |   1 +
>  tests/qemuxml2argvtest.c                           | 125 +++++++++++++----
>  .../qemuxml2xmlout-aarch64-gic-none-both.xml       |   1 +
>  .../qemuxml2xmlout-aarch64-gic-none-v2.xml         |   1 +
>  .../qemuxml2xmlout-aarch64-gic-none-v3.xml         |   1 +
>  tests/qemuxml2xmltest.c                            | 155 ++++++++++++---------
>  tests/testutilsqemu.c                              |  36 +++++
>  tests/testutilsqemu.h                              |  10 ++
>  16 files changed, 361 insertions(+), 123 deletions(-)
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.args
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-both.xml
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.args
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v2.xml
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.args
>  create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-none-v3.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-both.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v2.xml
>  create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-gic-none-v3.xml

The series has been pushed after addressing the issues pointed
out during review. Thanks John!

-- 
Andrea Bolognani
Software Engineer - Virtualization Team


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]