[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/4] tests: qemuargv2xmltest: Drop disk for s390 aes tests



On Sat, 2016-05-14 at 17:39 -0400, Cole Robinson wrote:
> Upcoming patches are going to make the disk portion of these
> test cases fail. In order to make it work, we would need to
> extend the qemuargv2xml test infrastructure to handle qemuCaps.
> This is worthwhile to do at some point but isn't critical.
> 
> Instead just drop the offending portion, which isn't even the
> target of the test cases anyways
> ---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-aeskeywrap-off-argv.args | 4 +---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-aeskeywrap-off-argv.xml  | 5 -----
>  tests/qemuargv2xmldata/qemuargv2xml-machine-aeskeywrap-on-argv.args  | 4 +---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-aeskeywrap-on-argv.xml   | 5 -----
>  tests/qemuargv2xmldata/qemuargv2xml-machine-deakeywrap-off-argv.args | 4 +---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-deakeywrap-off-argv.xml  | 5 -----
>  tests/qemuargv2xmldata/qemuargv2xml-machine-deakeywrap-on-argv.args  | 4 +---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-deakeywrap-on-argv.xml   | 5 -----
>  tests/qemuargv2xmldata/qemuargv2xml-machine-keywrap-none-argv.args   | 4 +---
>  tests/qemuargv2xmldata/qemuargv2xml-machine-keywrap-none-argv.xml    | 5 -----
>  10 files changed, 5 insertions(+), 40 deletions(-)

ACK if my explanation in 6/4 was correct.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]