[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v4 00/14] improve graphics listen configuration



The first 8 patches are cleanups and refactors of the graphics code.

9th patch introduces listen type socket and updates VNC graphics to use that
new listen type.

Patches 10 and 11 implements listen type socket for SPICE graphics and patch 12
adds spice_auto_unix_socket config option into qemu.conf.

The last two patches introduces and implements new listen type none for VNC and
SPICE graphics.

The listen type none and socket are required to enable OpenGL support for SPICE
graphics.

Changes in v4:
    - removed the port patch that will be posted later as separate patch series
    - reordered some patches and added some more cleanups

Changes in v3:
    - add listen type none support for vnc
    - fix issues pointed out in v2

Changes in v2:
    - don't remove vnc_auto_unix_socket from qemu.conf
    - add spice_auto_unix_socket

Pavel Hrdina (14):
  qemu_domain: add a empty listen type address if we remove socket for
    VNC
  tests: cleanup vnc auto socket test
  graphics: rename gListen to glisten
  domain_conf: introduce virDomainGraphicsAddListenAddr
  qemu_command: move sasl parameter after port and addr definition
  graphics: resolve address for listen type network in qemu_process
  qemu_process: separate graphics socket and address generation
  qemu_command: refactor spice channel code
  graphics: introduce listen type socket and use it for VNC
  qemu_capabilites: add QEMU_CAPS_SPICE_UNIX
  spice: add support for listen type socket
  spice: introduce spice_auto_unix_socket config option
  spice: introduce listen type none
  vnc: add support for listen type none

 docs/formatdomain.html.in                          |  28 ++
 docs/schemas/domaincommon.rng                      |  15 +
 src/conf/domain_conf.c                             | 314 ++++++++++++++++-----
 src/conf/domain_conf.h                             |   8 +-
 src/libvirt_private.syms                           |   1 +
 src/libxl/libxl_conf.c                             |  16 +-
 src/qemu/libvirtd_qemu.aug                         |   1 +
 src/qemu/qemu.conf                                 |  17 +-
 src/qemu/qemu_capabilities.c                       |   3 +
 src/qemu/qemu_capabilities.h                       |   3 +
 src/qemu/qemu_command.c                            | 276 ++++++++----------
 src/qemu/qemu_conf.c                               |   1 +
 src/qemu/qemu_conf.h                               |   1 +
 src/qemu/qemu_domain.c                             |  34 ++-
 src/qemu/qemu_hotplug.c                            |   9 +
 src/qemu/qemu_migration.c                          |  49 +++-
 src/qemu/qemu_parse_command.c                      |   2 +-
 src/qemu/qemu_process.c                            | 130 +++++++--
 src/qemu/test_libvirtd_qemu.aug.in                 |   1 +
 src/security/virt-aa-helper.c                      |  15 +-
 src/vbox/vbox_common.c                             |  10 +-
 src/vmx/vmx.c                                      |   8 +-
 src/vz/vz_sdk.c                                    |   8 +-
 src/xenconfig/xen_common.c                         |  14 +-
 src/xenconfig/xen_sxpr.c                           |  16 +-
 src/xenconfig/xen_xl.c                             |   8 +-
 ...ric-graphics-vnc-socket-attr-listen-address.xml |  30 ++
 ...hics-vnc-socket-attr-listen-socket-mismatch.xml |  30 ++
 ...eric-graphics-vnc-socket-attr-listen-socket.xml |  30 ++
 ...ric-graphics-vnc-socket-attr-listen-address.xml |  30 ++
 ...eric-graphics-vnc-socket-attr-listen-socket.xml |  30 ++
 .../generic-graphics-vnc-socket-listen.xml         |   4 +-
 .../generic-graphics-vnc-socket.xml                |   4 +-
 tests/genericxml2xmltest.c                         |   4 +
 .../qemuargv2xml-graphics-vnc-socket.xml           |   4 +-
 ...emuxml2argv-graphics-spice-auto-socket-cfg.args |  20 ++
 ...qemuxml2argv-graphics-spice-auto-socket-cfg.xml |  30 ++
 .../qemuxml2argv-graphics-spice-auto-socket.args   |  20 ++
 .../qemuxml2argv-graphics-spice-auto-socket.xml    |  30 ++
 .../qemuxml2argv-graphics-spice-sasl.args          |   2 +-
 .../qemuxml2argv-graphics-spice-socket.args        |  20 ++
 .../qemuxml2argv-graphics-spice-socket.xml         |  30 ++
 .../qemuxml2argv-graphics-vnc-auto-socket-cfg.args |  22 ++
 .../qemuxml2argv-graphics-vnc-auto-socket-cfg.xml  |  34 +++
 .../qemuxml2argv-graphics-vnc-auto-socket.args     |  20 ++
 .../qemuxml2argv-graphics-vnc-auto-socket.xml      |  30 ++
 .../qemuxml2argv-graphics-vnc-autosocket.args      |  22 --
 .../qemuxml2argv-graphics-vnc-autosocket.xml       |  34 ---
 .../qemuxml2argv-graphics-vnc-none.args            |  20 ++
 .../qemuxml2argv-graphics-vnc-none.xml             |  30 ++
 ...2argv-graphics-vnc-remove-generated-socket.args |  22 ++
 ...l2argv-graphics-vnc-remove-generated-socket.xml |  34 +++
 .../qemuxml2argv-graphics-vnc-socket.args          |   4 +-
 .../qemuxml2argv-graphics-vnc-socket.xml           |  10 +-
 .../qemuxml2argv-video-virtio-gpu-spice-gl.args    |   2 +-
 tests/qemuxml2argvtest.c                           |  18 ++
 ...muxml2xmlout-graphics-spice-auto-socket-cfg.xml |  35 +++
 .../qemuxml2xmlout-graphics-spice-auto-socket.xml  |  35 +++
 .../qemuxml2xmlout-graphics-spice-socket.xml       |  35 +++
 ...qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml |  41 +++
 .../qemuxml2xmlout-graphics-vnc-auto-socket.xml    |  35 +++
 .../qemuxml2xmlout-graphics-vnc-autosocket.xml     |  39 ---
 ...graphics-vnc-remove-generated-socket-active.xml |  41 +++
 ...aphics-vnc-remove-generated-socket-inactive.xml |  41 +++
 .../qemuxml2xmlout-graphics-vnc-socket.xml         |  35 +++
 .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml   |   4 +-
 tests/qemuxml2xmltest.c                            |  20 +-
 67 files changed, 1530 insertions(+), 439 deletions(-)
 create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-address.xml
 create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-socket-mismatch.xml
 create mode 100644 tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-socket.xml
 create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-socket-attr-listen-address.xml
 create mode 100644 tests/genericxml2xmloutdata/generic-graphics-vnc-socket-attr-listen-socket.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket-cfg.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket-cfg.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-auto-socket.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-socket.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-socket.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket-cfg.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket-cfg.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.xml
 delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.args
 delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-autosocket.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-none.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-none.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-remove-generated-socket.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-remove-generated-socket.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket-cfg.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-auto-socket.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-socket.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-socket.xml
 delete mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-autosocket.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-remove-generated-socket-active.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-remove-generated-socket-inactive.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-socket.xml

-- 
2.8.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]