[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 3/6] util: Introduce virCryptoGenerateRandom



On Thu, May 19, 2016 at 16:29:02 -0400, John Ferlan wrote:
> Move the logic from qemuDomainGenerateRandomKey into this new
> function, altering the comments, variable names, and error messages
> to keep things more generic.
> 
> NB: Although perhaps more reasonable to add soemthing to virrandom.c.
>     The virrandom.c was included in the setuid_rpc_client, so I chose
>     placement in vircrypto.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/libvirt_private.syms |  1 +
>  src/qemu/qemu_domain.c   | 53 ++----------------------------------------------
>  src/util/vircrypto.c     | 41 +++++++++++++++++++++++++++++++++++++
>  src/util/vircrypto.h     |  2 ++
>  4 files changed, 46 insertions(+), 51 deletions(-)

ACK

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]