[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 6/8] nwfilter: Replace VIR_ERROR with standard vir*Error in state driver init



On 05/23/2016 02:35 PM, Jovanka Gulicoska wrote:
> Replace VIR_ERROR with virReportError
> ---
>  src/nwfilter/nwfilter_driver.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c
> index 2828b28..186830c 100644
> --- a/src/nwfilter/nwfilter_driver.c
> +++ b/src/nwfilter/nwfilter_driver.c
> @@ -215,8 +215,9 @@ nwfilterStateInitialize(bool privileged,
>       */
>      if (sysbus &&
>          nwfilterDriverInstallDBusMatches(sysbus) < 0) {
> -        VIR_ERROR(_("DBus matches could not be installed. Disabling nwfilter "
> -                  "driver"));
> +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                       _("DBus matches could not be installed. "
> +                       "Disabling nwfilter driver"));
>          /*
>           * unfortunately this is fatal since virNWFilterTechDriversInit
>           * may have caused the ebiptables driver to use the firewall tool
> 

Thanks, I pushed this

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]