[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: completely rework reference counting



On 20.05.2016 17:17, Katerina Koukiou wrote:
> This patch follows the pattern used in qemu driver regarding
> reference counting.
> It changes lxcDomObjFromDomain() to ref the domain (using
> virDomainObjListFindByUUIDRef()) and adds virDomainObjEndAPI() which
> should be the only function in which the return value of
> virObjectUnref() is checked.  This makes all reference counting
> deterministic and makes the code a bit clearer.
> 
> Signed-off-by: Katerina Koukiou <k koukiou gmail com>
> ---
>  src/lxc/lxc_domain.c |  16 +---
>  src/lxc/lxc_domain.h |   5 +-
>  src/lxc/lxc_driver.c | 216 +++++++++++++++++++--------------------------------
>  3 files changed, 85 insertions(+), 152 deletions(-)
> 
> diff --git a/src/lxc/lxc_domain.c b/src/lxc/lxc_domain.c
> index bca2bb2..6fd5423 100644
> --- a/src/lxc/lxc_domain.c
> +++ b/src/lxc/lxc_domain.c
> @@ -80,7 +80,7 @@ virLXCDomainObjFreeJob(virLXCDomainObjPrivatePtr priv)
>   * in any way
>   *
>   * Upon successful return, the object will have its ref count increased,
> - * successful calls must be followed by EndJob eventually
> + * Successful calls must be followed by EndJob eventually
>   */

If you're changing this, there should be a full stop at the end of
previous sentence. And at the end of this sentence too.

>  int
>  virLXCDomainObjBeginJob(virLXCDriverPtr driver ATTRIBUTE_UNUSED,


I've fixed that, ACKed and pushed this one.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]