[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] esx: Add VMCI device for virtualHW >= 7



2016-05-23 23:22 GMT+02:00 Dawid Zamirski <dzamirski datto com>:
> This patch fixes an issue where vMotion fails when VMCI device is not
> present in the vmx file.
> ---
>  src/vmx/vmx.c                                       | 2 ++
>  tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx  | 1 +
>  tests/xml2vmxdata/xml2vmx-serial-network-client.vmx | 1 +
>  tests/xml2vmxdata/xml2vmx-serial-network-server.vmx | 1 +
>  tests/xml2vmxdata/xml2vmx-ws-in-the-wild-1.vmx      | 1 +
>  tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx      | 1 +
>  6 files changed, 7 insertions(+)
>
> diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
> index 5b98dac..c8acc9f 100644
> --- a/src/vmx/vmx.c
> +++ b/src/vmx/vmx.c
> @@ -3403,6 +3403,8 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLOptionPtr xmlopt, virDomainDe
>              virBufferAddLit(&buffer, "pciBridge7.virtualDev = \"pcieRootPort\"\n");
>              virBufferAddLit(&buffer, "pciBridge7.functions = \"8\"\n");
>          }
> +
> +        virBufferAddLit(&buffer, "vmci0.present = \"true\"\n");
>      }

And now I see why you had the nested if in the other patch. Sorry for
messing this up.

Anyway, ACK and pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]