[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: update to latest gnulib



On 05/26/2016 11:07 PM, Eric Blake wrote:
> On 05/26/2016 09:52 AM, Eric Blake wrote:
>> Pulls in several portability fixes, including the fact that gnulib
>> now only works on platforms with two's complement signed integers.
>> Also makes for a smaller delta on the next update (we are waiting
>> on a license change to unsetenv for the sake of mingw).
>>
>> * .gnulib: Update to latest.
>> * bootstrap: Resync from upstream.
>> * tests/virstringtest.c: Drop use of obsolete probes of integer
>> properties.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>
>> I'd like to get this in now, before RC1 is cut, so that we maximize
>> the testing of the bulk of the gnulib changes (rather than waiting
>> for the unsetenv change needed for mingw to land, but forcing the
>> gnulib update to only get testing in RC2).
> 
> Pushed under gnulib maintenance rule, since RC1 still hasn't been tagged.
> 

FWIW On Fedora 24 I'm not getting the issue that others are reporting, but
there's this new build warning/error after the gnulib update:

In file included from ../include/libvirt/libvirt.h:38:0,
                 from ./internal.h:58,
                 from util/virlog.h:25,
                 from util/virarch.c:26:
../include/libvirt/libvirt-domain.h:1881:57: error: result of '1 << 31'
requires 33 bits to represent, but 'int' only has 32 bits
[-Werror=shift-overflow=]
     VIR_CONNECT_GET_ALL_DOMAINS_STATS_ENFORCE_STATS = 1 << 31, /* enforce
requested stats */

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]