[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Removed function virDomainDefNewFull.



On Fri, May 27, 2016 at 04:20:09PM +0200, Tomáš Ryšavý wrote:
> The function virDomainDefNewFull() in src/conf/domain_conf.c was a thin
> wrapper around virDomainDefNew() that was only used in a few places in
> the code. The function was removed and the callers were re-implemented.
> ---

What is the motivation for this change?

Personally, I would rather keep the thin wrapper than open code it
everywhere.

Jan

>  src/conf/domain_conf.c   | 22 ----------------------
>  src/conf/domain_conf.h   |  3 ---
>  src/libvirt_private.syms |  1 -
>  src/vz/vz_utils.c        |  8 +++++++-
>  src/xen/xen_hypervisor.c | 26 ++++++++++++++++++--------
>  src/xen/xend_internal.c  | 23 +++++++++++++++++++----
>  src/xen/xm_internal.c    | 24 ++++++++++++++++++++++--
>  7 files changed, 66 insertions(+), 41 deletions(-)
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]