[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/6] qemuMonitorTextGetAllBlockStatsInfo: Fix line validation



On Tue, May 31, 2016 at 12:33:30 +0200, Michal Privoznik wrote:
> There's a bug in the function. We expect the following format for
> the data we are parsing here:
> 
>   key: value
> 
> So we use strchr() to find ':' and then see if it is followed by
> space. Well, the condition which checks that - we got it wrong.

The last sentence doesn't make much sense.

> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_monitor_text.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]