[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/6] virNetDevBridgeGet: Avoid NULL dereference



On Tue, May 31, 2016 at 12:33:25 +0200, Michal Privoznik wrote:
> It may happen, that this function would dereference a NULL
> pointer:
> 
> util/virnetdevbridge.c: In function 'virNetDevBridgeGetVlanFiltering':
> util/virnetdevbridge.c:199:23: error: null pointer dereference [-Werror=null-dereference]
>          ifr->ifr_data = (char*)&args;
>          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/util/virnetdevbridge.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

How about fixing the single caller that passes NULL in @ifr?

virNetDevBridgeGetVlanFiltering

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]