[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] qemu: Move and rename qemuBuildObjectCommandlineFromJSON



On Fri, May 27, 2016 at 09:57:07 -0400, John Ferlan wrote:
> Move the module from qemu_command.c to virjson.c and rename to
> virJSONBuildObjectCommandline.
> 
> Nothing in the API is "specific" to the qemuBuild* processing and it'll
> be useful to "share" with upcoming changes in the storage_backend which
> will build a secret object for the 'qemu-img' command.

It's very specific to qemu. Either qemu-img or qemu itself it's still
qemu.

> Also virJSONValueObjectForeachKeyValue and virJSONValueGetArrayAsBitmap
> can be static helpers.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/libvirt_private.syms    |   3 +-
>  src/qemu/qemu_command.c     | 124 +++-----------------------------------------
>  src/qemu/qemu_command.h     |   4 --
>  src/util/virjson.c          | 117 +++++++++++++++++++++++++++++++++++++++--
>  src/util/virjson.h          |  12 ++---
>  tests/qemucommandutiltest.c |   7 +--
>  6 files changed, 129 insertions(+), 138 deletions(-)

I'm leaning towards rejecting to add this to the JSON helpers. Maybe we
need a new file for qemu specific helper functions to share accross
modules.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]