[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: always format os.bootloaderArgs if set



On Tue, May 31, 2016 at 08:06:06PM +0200, Fabian Freyer wrote:
At the moment the bootloader arguments never get formatted if the
bootloader is unset. However, in cases where the bootloader defaults to
a default value when unset, specifying bootloader arguments does make
sense.

Please wrap long lines.  If the bootloader defaults to something, it
should be set to that default.  So NACK to this approach (unless I
missed something).

---
src/conf/domain_conf.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 568c699..66bba6e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -22608,6 +22608,8 @@ virDomainDefFormatInternal(virDomainDefPtr def,
    if (def->os.bootloader) {
        virBufferEscapeString(buf, "<bootloader>%s</bootloader>\n",
                              def->os.bootloader);
+    }
+    if (def->os.bootloaderArgs) {

the conditions would not be needed, look at how virBufferEscapeString()
works.

        virBufferEscapeString(buf,
                              "<bootloader_args>%s</bootloader_args>\n",
                              def->os.bootloaderArgs);
--
2.7.0

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]