[libvirt] [PATCH 04/17] docs: add footer to all pages

[Peter Krempa]

On Fri, Nov 04, 2016 at 13:55:31 +0000, Daniel Berrange wrote:
> On Fri, Nov 04, 2016 at 02:19:22PM +0100, Ján Tomko wrote:
> > On Mon, Oct 31, 2016 at 12:41:45PM +0000, Daniel P. Berrange wrote:
> > > Add a footer to all pages containing a blurb about the
> > > code of conduct, and links to social media sites.
> > > 
> > > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > > ---
> > > docs/libvirt.css | 44 ++++++++++++++++++++++++++++++++++++++++++++
> > > docs/page.xsl    | 12 ++++++++++++
> > > 2 files changed, 56 insertions(+)
> > > 
> > 
> > > diff --git a/docs/page.xsl b/docs/page.xsl
> > > index e3b8d5b..8f6a8c7 100644
> > > --- a/docs/page.xsl
> > > +++ b/docs/page.xsl
> > > @@ -170,6 +170,18 @@
> > >             </form>
> > >           </div>
> > >         </div>
> > > +        <div id="footer">
> > > +          <div id="social">
> > > +            <ul>
> > > +              <li><a href="https://twitter.com/hashtag/libvirt">twitter</a></li>
> > 
> > This is essentially an ad for twitter. Unless they are sponsoring the
> > project, it feels out of place here.
> 
> Errr, it is linking to libvirt related content people share on twitter.

I find it a bit weird that we are promoting random content on a social
media site on every single page, but our frontpage does not contain a
link to the mailing list, which is primary communication mean.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161107/0b830acf/attachment-0001.sig>