[libvirt] [PATCH v6 15/17] qemu: initially reserve one open pcie-root-port for hotplug

[Andrea Bolognani]

On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote:
[...]
> Instead this patch just reserves one slot for a "future potential"
> PCIe device after doing the assignment for actual devices, but only
> if the only PCI controller defined prior to starting address
> assignment was pcie-root, and only if we auto-added at least one PCI
> controller during address assignment.  This assures two things:

Double space here. I wouldn't normally care about picking
one style over the other, but you've used a single space
everywhere else in the commit message :)

[...]
> This is set to reserve a single free port for now, but could be
> increased in the future if public sentiment goes in that direction
> (it's easy to increase later, but essential impossible to decrease)

s/essential/essentially/

[...]
> diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
> index fbbcfb2..15d7c1a 100644
> --- a/src/qemu/qemu_domain_address.c
> +++ b/src/qemu/qemu_domain_address.c
> @@ -1929,6 +1929,36 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def,
>          if (qemuDomainAssignDevicePCISlots(def, qemuCaps, addrs) < 0)
>              goto cleanup;
>  
> +        /* Only for *new* domains with pcie-root (and no other
> +         * manually specified PCI controllers in the definition): If,
> +         * after assigning addresses/reserving slots for all devices,
> +         * we see that any extra buses have been auto-added, we
> +         * understand that the application has left management of PCI
> +         * addresses and controllers up to libvirt. In order to allow
> +         * such applications to easily support hotplug, we will do a
> +         * "one time" reservation of one extra PCIE|HOTPLUGGABLE
> +         * slots, which should cause su to auto-add 1 extra

s/cause su/cause us/

> +         * pcie-root-ports The single slot in this root-port will be

s/pcie-root-ports/pcie-root-port./


ACK with the typos fixed.

-- 
Andrea Bolognani / Red Hat / Virtualization