[libvirt] [PATCH 0/4] admin: Fix a leaking conn reference and other improvements
Michal Privoznik
mprivozn at redhat.com
Fri Nov 11 15:51:38 UTC 2016
On 11.11.2016 16:32, Erik Skultety wrote:
> This series fixes a memory leak in a dangling conn object reference caused by
> assigning NULL to conn->closeCallback object by the RPC catch-disconnect routine
> followed by a comparison of equality of conn->closeCallback->callback and the
> client-registered callback reference.
> Before fixing the issue itself, there are some new helpers introduced following
> the same idea as the helpers introduced by series
> https://www.redhat.com/archives/libvir-list/2016-February/msg00849.html
>
>
> Erik Skultety (4):
> vsh: Drop conditional error reporting in vshErrorHandler
> admin: Remove unnecessary @conn object locking
> datatypes: Introduce some admin-related close callback handling
> helpers
> admin: Use the newly introduced close callback handling helpers
>
> po/POTFILES.in | 1 +
> src/admin/admin_remote.c | 6 +---
> src/datatypes.c | 67 +++++++++++++++++++++++++++++++++++++++---
> src/datatypes.h | 8 +++++
> src/libvirt-admin.c | 24 +--------------
> src/libvirt_admin_private.syms | 3 ++
> tools/vsh.c | 2 --
> 7 files changed, 77 insertions(+), 34 deletions(-)
>
ACK series
Michal
More information about the libvir-list
mailing list