[libvirt] [PATCH v3] qemu: fix command line building for iommu devices

Ján Tomko jtomko at redhat.com
Tue Oct 4 10:23:19 UTC 2016


On Mon, Oct 03, 2016 at 04:48:35PM +0100, Daniel P. Berrange wrote:
>The intel-iommu device has existed since QEMU 2.2.0, but
>it was only possible to create it with -device since
>QEMU 2.7.0, thanks to:
>
>  commit 621d983a1f9051f4cfc3f402569b46b77d8449fc
>  Author: Marcel Apfelbaum <marcel at redhat.com>
>  Date:   Mon Jun 27 18:38:34 2016 +0300
>
>    hw/iommu: enable iommu with -device
>
>    Use the standard '-device intel-iommu' to create the IOMMU device.
>    The legacy '-machine,iommu=on' can still be used.
>
>The libvirt capability check & command line formatting code
>is thus broken for all QEMU versions 2.2.0 -> 2.6.0 inclusive.
>
>This fixes it to use iommu=on instead.
>
>Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
>---
> src/qemu/qemu_capabilities.c                       | 12 +++++++
> src/qemu/qemu_capabilities.h                       |  1 +
> src/qemu/qemu_command.c                            | 22 +++++++++++++
> tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  2 +-
> tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  2 +-
> tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  2 +-
> .../qemuxml2argv-intel-iommu-machine.args          | 21 ++++++++++++
> .../qemuxml2argv-intel-iommu-machine.xml           | 37 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  2 ++
> 9 files changed, 98 insertions(+), 3 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-machine.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-machine.xml
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161004/fa23113f/attachment-0001.sig>


More information about the libvir-list mailing list