[libvirt] [PATCH v2 08/14] qemuBuildHostNetStr: Explicitly enumerate net types

Michal Privoznik mprivozn at redhat.com
Thu Oct 6 13:38:54 UTC 2016


We tend to prevent using 'default' in switches. And it is for a
good reason - control may end up in paths we wouldn't want for
new values. In this specific case, if qemuBuildHostNetStr is
called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would produce
meaningless output. Fortunately, there no such call yet.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_command.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index cc3b24f..4a67d80 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3711,9 +3711,21 @@ qemuBuildHostNetStr(virDomainNetDefPtr net,
         break;
 
     case VIR_DOMAIN_NET_TYPE_USER:
-    default:
+    case VIR_DOMAIN_NET_TYPE_INTERNAL:
         virBufferAddLit(&buf, "user");
         break;
+
+    case VIR_DOMAIN_NET_TYPE_HOSTDEV:
+        /* Should have been handled earlier via PCI/USB hotplug code. */
+        virObjectUnref(cfg);
+        return NULL;
+
+    case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
+        /* Unsupported yet. */
+        break;
+
+    case VIR_DOMAIN_NET_TYPE_LAST:
+        break;
     }
 
     if (vlan >= 0) {
-- 
2.8.4




More information about the libvir-list mailing list