[libvirt] [PATCH] xl: don't output (null) target in domxml-to-native

[Michal Privoznik]

On 20.10.2016 02:23, John Ferlan wrote:
> 
> 
> On 10/19/2016 06:10 AM, Cédric Bosdonnat wrote:
>> When converting a domain xml containing a CDROM device without
>> any attached source, don't add a target=(null) to the libxl config
>> disk definition: xen doesn't like it at all and would fail to start
>> the domain.
>> ---
>>  src/xenconfig/xen_xl.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
> 
> After your push, make check for xlconfigtest is now broken (at least on
> my Fedora run)

Moreover, while your subsequent patch fixes the tests, I think that your
first patch was correct and the rest is broken. I mean we should have
the following pattern:

virBufferAdd(buf, "arg1");
if (cond1)
  virBufferAdd(buf, ",arg2");
if (cond2)
  virBufferAdd(buf, ",arg3");

and so on. Currently, the commas are after arg1, arg2, and arg3.

Michal