[libvirt] [PATCH] qemu: Break endless loop if qemuMigrationResetTLS fails

Jiri Denemark jdenemar at redhat.com
Tue Apr 4 12:29:58 UTC 2017


On Tue, Apr 04, 2017 at 07:53:55 -0400, John Ferlan wrote:
> 
> 
> On 04/04/2017 06:48 AM, Jiri Denemark wrote:
> > Jumping to "endjob" label from a code after this label is not a very
> > good idea.
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/qemu/qemu_migration.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> 
> D'oh... Not sure if it's too late, but wrap in ignore_value(); similar
> to qemuMigrationPrepareAny failure

Why? The ignore_value macro is only needed when the function is declared
with ATTRIBUTE_RETURN_CHECK.

Jirka




More information about the libvir-list mailing list