[libvirt] [PATCH 02/38] fdstreamtest: Print more info on read failure

Michal Privoznik mprivozn at redhat.com
Thu Apr 13 13:31:10 UTC 2017


It helps with debugging if we know what's the return value of
saferead().

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/fdstreamtest.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/fdstreamtest.c b/tests/fdstreamtest.c
index 5e82dac..68a5bc3 100644
--- a/tests/fdstreamtest.c
+++ b/tests/fdstreamtest.c
@@ -250,14 +250,16 @@ static int testFDStreamWriteCommon(const char *scratchdir, bool blocking)
         goto cleanup;
 
     for (i = 0; i < 10; i++) {
-        size_t want;
+        size_t want, got;
         if (i == 9)
             want = PATTERN_LEN / 2;
         else
             want = PATTERN_LEN;
 
-        if (saferead(fd, buf, want) != want) {
-            virFilePrintf(stderr, "Short read from data\n");
+        if ((got = saferead(fd, buf, want)) != want) {
+            virFilePrintf(stderr,
+                          "Short read from data, i=%zu got=%zu want=%zu\n",
+                          i, got, want);
             goto cleanup;
         }
 
-- 
2.10.2




More information about the libvir-list mailing list